Skip to content

Add helm chart for running benchmark tool #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add helm chart for running benchmark tool #1665

wants to merge 1 commit into from
+213 −101

Conversation

dharaneeshvrd
Copy link

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add helm chart for running benchmark tool.

Which issue(s) this PR fixes:

Fixes #528

Does this PR introduce a user-facing change?:

Add helm chart for running benchmark tool.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 29, 2025
@netlify Netlify
Copy link

netlify bot commented Sep 29, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 15f97cb
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68daa539bb547800080f05a9
😎 Deploy Preview https://deploy-preview-1665--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dharaneeshvrd
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 29, 2025
@dharaneeshvrd
Copy link
Author

/cc @liu-cong

@dharaneeshvrd dharaneeshvrd changed the title [WIP] Add helm chart for running benchmark tool Add helm chart for running benchmark tool Sep 30, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2025
@dharaneeshvrd
Copy link
Author

Hi @danehans @kfswain @liu-cong
Can you please review this PR when you get a chance?

@liu-cong
Copy link
Contributor

liu-cong commented Oct 8, 2025

cc @rlakhtakia

@liu-cong
Copy link
Contributor

liu-cong commented Oct 9, 2025

@rlakhtakia Can you review this and perhaps align the benchmark improvement work you are doing currently?

@kfswain
Copy link
Collaborator

kfswain commented Oct 9, 2025

@rlakhtakia Can you review this and perhaps align the benchmark improvement work you are doing currently?

Agreed, unfortunately this is converting the LPG to helm, so while I appreciate this effort, we actually use Inference-Perf for benchmarking now.

I created this to reflect that: #1688

@dharaneeshvrd
Copy link
Author

@kfswain
Please free to close the PR if you think this is not required anymore

@kfswain
Copy link
Collaborator

kfswain commented Oct 14, 2025

Apologies, I'll close this in favor of: #1689

@kfswain kfswain closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danehans danehans Awaiting requested review from danehans

@kfswain kfswain Awaiting requested review from kfswain

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a helm chart to parameterize the benchmark guide so users don't need to fork the repo

4 participants

@dharaneeshvrd @k8s-ci-robot @liu-cong @kfswain